From 0688b2ec24a87ff4723dad27dbd98eb3f479b50b Mon Sep 17 00:00:00 2001 From: anatolykopyl Date: Thu, 19 May 2022 23:40:19 +0300 Subject: [PATCH] Fixed infinite loop in createEffect --- src/components/Controls.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/components/Controls.tsx b/src/components/Controls.tsx index 2f8e882..6a48363 100644 --- a/src/components/Controls.tsx +++ b/src/components/Controls.tsx @@ -26,10 +26,12 @@ export default () => { } } - createEffect(() => { - selectChapter(store.visibleChapter()); + createEffect((prev) => { + if (prev !== store.visibleChapter()) { + selectChapter(store.visibleChapter()); + } return store.visibleChapter(); - }, 'home'); + }); return ( <> @@ -47,7 +49,9 @@ export default () => {
{(control) =>
selectChapter(control.name)} + onClick={() => { + selectChapter(control.name) + }} class={styles.control} >